Upgrade pyproject-hooks to 1.2.0 #13125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
commented
Dec 23, 2024
| @@ -38,4 +38,5 @@ def generate_editable_metadata( | |||
| except InstallationSubprocessError as error: | |||
| raise MetadataGenerationFailed(package_details=details) from error | |||
|
|
|||
| assert distinfo_dir is not None | |||
There was a problem hiding this comment.
I don't think this should be necessary given that prepare_metadata_for_build_wheel() on the super class is typed to return str. This seems an oversight when type annotations were added to pyproject-hooks. I've asked around whether this is intentional.
There was a problem hiding this comment.
See also pypa/pyproject-hooks#209 where I propose fixing prepare_metadata_for_build_editable()'s return type to str.
ichard26
force-pushed
the
pyproject-hooks
branch
from
f37cdae to
a670a6a
Compare
sbidoul
approved these changes
Jan 4, 2025
|
Ah, the pyproject-hooks issue was seemingly fixed by pypa/setuptools#4680. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #13103.
We may be affected by pypa/pyproject-hooks#206. PTAL.